lkml.org 
[lkml]   [2007]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] UML - audio driver formatting
On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote:

> Jeff Dike wrote:
> > Whitespace and style fixes.
> >
> > Signed-off-by: Jeff Dike <jdike@addtoit.com>
> > --
> > arch/um/drivers/hostaudio_kern.c | 160 +++++++++++++++++----------------------
> > 1 file changed, 73 insertions(+), 87 deletions(-)
> >
> > Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c
> > ===================================================================
> > --- linux-2.6.18-mm.orig/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:41.000000000 -0500
> > +++ linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:42.000000000 -0500
> > @@ -15,11 +15,11 @@
> > #include "os.h"
> >
> > struct hostaudio_state {
> > - int fd;
> > + int fd;
> > };
> >
> > struct hostmixer_state {
> > - int fd;
> > + int fd;
> > };
> >
> > #define HOSTAUDIO_DEV_DSP "/dev/sound/dsp"
> > @@ -72,12 +72,12 @@ MODULE_PARM_DESC(mixer, MIXER_HELP);
> > static ssize_t hostaudio_read(struct file *file, char __user *buffer,
> > size_t count, loff_t *ppos)
> > {
> > - struct hostaudio_state *state = file->private_data;
> > + struct hostaudio_state *state = file->private_data;
> > void *kbuf;
> > int err;
> >
> > #ifdef DEBUG
> > - printk("hostaudio: read called, count = %d\n", count);
> > + printk("hostaudio: read called, count = %d\n", count);
> > #endif
> >
> > kbuf = kmalloc(count, GFP_KERNEL);
> > @@ -91,7 +91,7 @@ static ssize_t hostaudio_read(struct fil
> > if(copy_to_user(buffer, kbuf, err))
> > err = -EFAULT;
> >
> > - out:
> > +out:
> >
> Isn't labels _suppose_ to be spaced? (due to "grep", if I'm not mistaken)...

There was some noise about that (due to 'patch' IIRC).
I tested it and could not cause a problem with labels beginning
in column 0. Can you?

> > kfree(kbuf);
> > return(err);
> > }



---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-02 03:39    [W:0.048 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site