Messages in this thread | | | Subject | Re: [PATCH] watchdog: add support for w83697hg chip | From | Alan Cox <> | Date | Sat, 09 Sep 2006 16:25:25 +0100 |
| |
Ar Mer, 2006-09-06 am 12:29 +0200, ysgrifennodd Samuel Tardieu: > +static unsigned char > +w83697hg_get_reg(unsigned char reg) > +{ > + outb_p(reg, W83697HG_EFIR); > + return inb_p(W83697HG_EFDR); > +}
No kernel level locking anywhere in the driver. Yet you could have two people accessing it at once.
> +wdt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, > + unsigned long arg) > +{ > + default: > + return -ENOIOCTLCMD;
Should be -ENOTTY
> + printk(KERN_INFO PFX "Looking for W83697HG at address 0x%x\n", wdt_io);
KERN_DEBUG
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |