Messages in this thread | | | Date | Thu, 07 Sep 2006 22:05:32 +0200 | From | Stefan Richter <> | Subject | Re: set power state of firewire host during suspend |
| |
Pavel Machek wrote: > Put firewire host controller in PCI Dx state for system suspend. > (I was not able to measure any power savings, but it sounds like right > thing to do, anyway.) > > Signed-off-by: Pavel Machek <pavel@suse.cz> [...] > --- a/drivers/ieee1394/ohci1394.c > +++ b/drivers/ieee1394/ohci1394.c > @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct > } > #endif > > + pci_set_power_state(pdev, pci_choose_state(pdev, state)); > return 0; > }
The order with existing PPC_PMAC code needs to be swapped. And the resume hook should set the power state too, right? I will post an update patch soon. -- Stefan Richter -=====-=-==- =--= --=== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |