lkml.org 
[lkml]   [2006]   [Sep]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 07 Sep 2006 00:18:48 -0400
FromJeff Garzik <>
SubjectRe: [PATCH] x86 microcode: don't check the size
Shaohua Li wrote:
> IA32 manual says if micorcode update's size is 0, then the size is
> default size (2048 bytes). But this doesn't suggest all microcode
> update's size should be above 2048 bytes to me. We actually had a
> microcode update whose size is 1024 bytes. The patch just removed the
> check.
> 
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Why not explicitly check for zero, rather than removing the questionable 
less-than test?  The default size logic hasn't disappeared...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-07 04:23    [from the cache]
©2003-2008