lkml.org 
[lkml]   [2006]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFT PATCH 2/2] ieee1394: nodemgr: grab class.subsys.rwsem in nodemgr_resume_ne
    nodemgr_resume_ne was iterating over nodemgr_ud_class.children without
    protection by nodemgr_ud_class.subsys.rwsem.

    FIXME:
    Shouldn't we rather use class->sem there, not class->subsys.rwsem?

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    ---
    Index: linux/drivers/ieee1394/nodemgr.c
    ===================================================================
    --- linux.orig/drivers/ieee1394/nodemgr.c 2006-09-06 18:34:35.000000000 +0200
    +++ linux/drivers/ieee1394/nodemgr.c 2006-09-06 18:38:20.000000000 +0200
    @@ -1352,6 +1352,7 @@ static void nodemgr_resume_ne(struct nod
    ne->in_limbo = 0;
    device_remove_file(&ne->device, &dev_attr_ne_in_limbo);

    + down_read(&nodemgr_ud_class.subsys.rwsem);
    down_read(&ne->device.bus->subsys.rwsem);
    list_for_each_entry(cdev, &nodemgr_ud_class.children, node) {
    ud = container_of(cdev, struct unit_directory, class_dev);
    @@ -1363,6 +1364,7 @@ static void nodemgr_resume_ne(struct nod
    ud->device.driver->resume(&ud->device);
    }
    up_read(&ne->device.bus->subsys.rwsem);
    + up_read(&nodemgr_ud_class.subsys.rwsem);

    HPSB_DEBUG("Node resumed: ID:BUS[" NODE_BUS_FMT "] GUID[%016Lx]",
    NODE_BUS_ARGS(ne->host, ne->nodeid), (unsigned long long)ne->guid);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-06 19:09    [W:0.022 / U:0.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site