Messages in this thread | | | Date | Wed, 6 Sep 2006 15:46:43 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 10/21] block: elevator selection and pinning |
| |
On Wed, Sep 06 2006, Peter Zijlstra wrote: > Provide an block queue init function that allows to set an elevator. And a > function to pin the current elevator. > > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> > Signed-off-by: Daniel Phillips <phillips@google.com> > CC: Jens Axboe <axboe@suse.de> > CC: Pavel Machek <pavel@ucw.cz>
Generally I don't think this is the right approach, as what you really want to do is let the driver say "I want intelligent scheduling" or not. The type of scheduler is policy that is left with the user, not the driver.
And this patch seems to do two things, and you don't explain what the pinning is useful for at all.
So that's 2 for 2 currently, NAK from me.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |