lkml.org 
[lkml]   [2006]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -mm] PM: Remove sleeping from suspend_console
Date
On Tuesday, 5 September 2006 08:28, Stefan Seyfried wrote:
> On Mon, Sep 04, 2006 at 10:50:40PM +0200, Rafael J. Wysocki wrote:
> > Remove ssleep() from suspend_console().
> >
> > Stefan thinks it is unnecessary and will slow down the suspend too much.
>
> "unnecessary" is not exactly what i think, rather "unacceptable" :-)

Still that implies it's not necessary. ;-)

> We probably need to do something for some kinds of consoles to make sure all
> characters are sent, but sleeping unconditionally is not the right thing IMO.

Yup. This was added as a result of the Laurent Riffard's report that the sleep
was necessary, but it turned out to be due to the network card problem, so we
should get rid of the ssleep().

Greetings,
Rafael


--
You never change things by fighting the existing reality.
R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-05 13:07    [from the cache]
©2003-2011 Jasper Spaans