[lkml]   [2006]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[NEW PATCH] VIA IRQ quirk behaviour change
    The most recent VIA IRQ quirk changes have broken various VIA devices for
    some users. We are not able to add these devices to the blacklist as they
    are also available in PCI-card form, and running the quirk on these devices
    brings us back to square one (running the VIA quirk on non-VIA boards where
    the quirk is not needed).

    This patch, based on suggestions from Sergey Vlasov, implements a scheme
    similar to but more restrictive than the scheme we had in 2.6.16 and
    earlier. It runs the quirk on all VIA hardware, but *only* if a VIA
    southbridge was detected on the system.

    Based on suggestions and much investigation from from Sergio Monteiro Basto,
    this patch also partially reverts commit
    93cffffa19960464a52f9c78d9a6150270d23785 from Bjorn Helgaas. It is not clear
    if this was ever the correct fix, see
    This patch additionally includes a change suggested by Linus in that thread,
    where we only quirk devices on non-legacy IRQs.
    There is still a downside to this patch: if the user inserts a VIA PCI card
    into a VIA-based motherboard, in some circumstances the quirk will also run on
    the VIA PCI card. This corner case is hard to avoid.

    Signed-off-by: Daniel Drake <>
    Andrew, please replace the current -mm patch with this one. The general idea
    is that we consider applying the quirk to a lot more devices than we currently
    do (more comparable to 2.6.16 and previous), but we add various bail-out
    conditions to actually end up applying the quirks much less.

    I am fairly confident that we'll still be quirking enough hardware to not
    cause any breakage, but we can't be sure until it has seen some testing. This
    is compile-tested only.

    Stian Jordet: You're on CC due to a discussion linked to from above where
    it appeared that you needed Bjorn's patch. Please test this patch against
    unmodified 2.6.17 or 2.6.18-rc and let us know if there are any problems.

    Index: linux/drivers/pci/quirks.c
    --- linux.orig/drivers/pci/quirks.c
    +++ linux/drivers/pci/quirks.c
    @@ -650,26 +650,59 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V
    * Some of the on-chip devices are actually '586 devices' so they are
    * listed here.
    +static int via_irq_fixup_needed = -1;
    + * As some VIA hardware is available in PCI-card form, we need to restrict
    + * this quirk to VIA PCI hardware built onto VIA-based motherboards only.
    + * We try to locate a VIA southbridge before deciding whether the quirk
    + * should be applied.
    + */
    +static const struct pci_device_id via_irq_fixup_tbl[] = {
    + {
    + .vendor = PCI_VENDOR_ID_VIA,
    + .device = PCI_ANY_ID,
    + .subvendor = PCI_ANY_ID,
    + .subdevice = PCI_ANY_ID,
    + .class = PCI_CLASS_BRIDGE_ISA << 8,
    + .class_mask = 0xffff00,
    + },
    + { 0, },
    static void quirk_via_irq(struct pci_dev *dev)
    u8 irq, new_irq;

    - new_irq = dev->irq & 0xf;
    +#ifdef CONFIG_X86_IO_APIC
    + if (nr_ioapics && !skip_ioapic_setup)
    + return;
    +#ifdef CONFIG_ACPI
    + if (acpi_irq_model != ACPI_IRQ_MODEL_PIC)
    + return;
    + if (via_irq_fixup_needed == -1)
    + via_irq_fixup_needed = pci_dev_present(via_irq_fixup_tbl);
    + if (!via_irq_fixup_needed)
    + return;
    + new_irq = dev->irq;
    + if (!new_irq || new_irq >= 15)
    + return;
    pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
    if (new_irq != irq) {
    - printk(KERN_INFO "PCI: VIA IRQ fixup for %s, from %d to %d\n",
    + printk(KERN_INFO "PCI: VIA PIC IRQ fixup for %s, from %d to %d\n",
    pci_name(dev), irq, new_irq);
    udelay(15); /* unknown if delay really needed */
    pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);

    * VIA VT82C598 has its device ID settable and many BIOSes
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2006-09-06 04:03    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean