lkml.org 
[lkml]   [2006]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups)
    At Tue, 5 Sep 2006 10:08:14 +0200,
    Pavel Machek wrote:
    >
    > > > Looks reasonable to me. Will you do the patch or should I ?
    > >
    > > Please (you) go ahead with it.
    >
    > Does it look okay?
    >
    > Signed-off-by: Pavel Machek <pavel@suse.cz>
    >
    > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
    > index 6d2412e..d8e51a6 100644
    > --- a/Documentation/CodingStyle
    > +++ b/Documentation/CodingStyle
    > @@ -46,6 +46,16 @@ used for indentation, and the above exam
    >
    > Get a decent editor and don't leave whitespace at the end of lines.
    >
    > +Bitfield variables should be indented like this:
    > +
    > + unsigned int foo :1;
    > +
    > +Avoid extra spaces around ! operator, and do not place spaces around (s.
    > +
    > + if (!buffer)
    > +
    > +is okay, if ( ! buffer ) is just ugly.
    > +

    I know I belong to an endagered species, but I still find
    if (! buffer)
    ...
    isn't so ugly.


    Takashi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-05 17:29    [W:0.022 / U:89.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site