lkml.org 
[lkml]   [2006]   [Sep]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 4 Sep 2006 15:02:41 +1000
FromNathan Scott <>
SubjectRe: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean
On Fri, Sep 01, 2006 at 03:21:13PM +0200, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@student.ltu.se>
> 
> Converting:
> 'B_FALSE' into 'false'
> 'B_TRUE'  into 'true'
> 'boolean_t' into 'bool'

Hmm, so your bool is better than the next guys bool[ean[_t]]? :)

Seems like it'll be a few more days until the next cleanup patch
to remove _that_, so we shouldn't go that path.  Since we do use
the current boolean_t somewhat inconsistently in XFS, I'd say we
should just toss the thing and use int.

I took the earlier patch and completed it, switching over to int
use in place of boolean_t in the few places it used - I'll merge
that at some point, when its had enough testing.

cheers.

-- 
Nathan

-- 
VGER BF report: U 0.496999
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-04 05:07    [from the cache]
©2003-2008