![]() | |||||||||||
Messages in this thread |
On Sun, 3 Sep 2006 01:15:10 +0200 Pavel Machek wrote: > Hi! > > > > Hm, it looks rather like a personal preference. > > > IMHO, it's harder to read without space... > > > > We have been tending toward not using space in cases like this > > (in my unscientific memory-based survey). > > > > So, just this morning I have seen questions and opinions about > > the following that could (or could not) use more documentation > > or codification and I'm sure that we could easily find more, > > but do we want to codify Everything?? > > > > > > 1. Kconfig help text should be indented (it's not indented in the > > GFS2 patches) > > > > 2. if (!condition1) /* no space between ! and condition1 */ > > > > 3. don't use C99-style // comments > > > > 4. unsigned int bitfield :<nr_bits>; > > Looks reasonable to me. Will you do the patch or should I ? Please (you) go ahead with it. Thanks, --- ~Randy -- VGER BF report: U 0.5 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-09-03 06:29 [from the cache] ©2003-2008 | |||||||||||