Messages in this thread | | | Date | Wed, 27 Sep 2006 20:58:24 +0000 | From | "Miguel Ojeda" <> | Subject | Re: [PATCH 2.6.18 real-V5] drivers: add lcd display support |
| |
On 9/26/06, Andrew Morton <akpm@osdl.org> wrote: > It's also probably-incorrect on big-endian CPUs. > Perhaps you should not > use bitops at all for this driver, use open-coded | > and &/~ instead?
Uhm, someone told me that they shouldn't be used because the kernel has generic functions for that.
I researched the kernel sources, and looking at bitops.h I found setbit(), so I tried to use it in the driver, althought I prefer standard |= and &=.
Are there more generic bitops kernel functions I may didn't find and I should use in the future?
Anyway, it's just a question: I will turn back the driver to use |= and &=, they look better to me too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |