lkml.org 
[lkml]   [2006]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 40/47] drivers/base: Platform notify needs to occur before drivers attach to the device
    Date
    From: Brian Walsh <brian@walsh.ws>

    The platform_notify call for Arm and PPC architectures needs to be called
    before the driver attaches to the device. The problem only presents itself
    when hotplugging certain devices while the driver is already loaded.

    Signed-off-by: Brian Walsh <brian@walsh.ws>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/base/core.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/base/core.c b/drivers/base/core.c
    index bc9f35c..b224bb4 100644
    --- a/drivers/base/core.c
    +++ b/drivers/base/core.c
    @@ -424,6 +424,10 @@ int device_add(struct device *dev)
    if ((error = kobject_add(&dev->kobj)))
    goto Error;

    + /* notify platform of device entry */
    + if (platform_notify)
    + platform_notify(dev);
    +
    dev->uevent_attr.attr.name = "uevent";
    dev->uevent_attr.attr.mode = S_IWUSR;
    if (dev->driver)
    @@ -488,10 +492,6 @@ int device_add(struct device *dev)
    class_intf->add_dev(dev, class_intf);
    up(&dev->class->sem);
    }
    -
    - /* notify platform of device entry */
    - if (platform_notify)
    - platform_notify(dev);
    Done:
    kfree(class_name);
    put_device(dev);
    --
    1.4.2.1
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-26 07:55    [W:0.023 / U:29.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site