lkml.org 
[lkml]   [2006]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] fix idiocy in asd_init_lseq_mdp()
--- Al Viro <viro@ftp.linux.org.uk> wrote:
> To whoever had written that code:
>
> a) priority of >> is higher than that of &
> b) priority of typecast is higher than that of any binary operator
> c) learn the fscking C

"whoever" would be Bottomley or someone at LTC.

My code in that spot has:
asd_write_reg_dword(asd_ha, LmSEQ_INTEN_SAVE(lseq),
(u32) LmM0INTEN_MASK);

>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/scsi/aic94xx/aic94xx_seq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c
> index d9b6da5..56e4b3b 100644
> --- a/drivers/scsi/aic94xx/aic94xx_seq.c
> +++ b/drivers/scsi/aic94xx/aic94xx_seq.c
> @@ -764,7 +764,7 @@ static void asd_init_lseq_mdp(struct asd
> asd_write_reg_word(asd_ha, LmSEQ_FIRST_INV_SCB_SITE(lseq),
> (u16)last_scb_site_no+1);
> asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq),
> - (u16) LmM0INTEN_MASK & 0xFFFF0000 >> 16);
> + (u16) ((LmM0INTEN_MASK & 0xFFFF0000) >> 16));
> asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq) + 2,
> (u16) LmM0INTEN_MASK & 0xFFFF);
> asd_write_reg_byte(asd_ha, LmSEQ_LINK_RST_FRM_LEN(lseq), 0);
> --
> 1.4.2.GIT
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-25 08:55    [W:0.058 / U:1.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site