lkml.org 
[lkml]   [2006]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]: PCI Error Recovery: Symbios SCSI device driver
    On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:

    > On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:
    > >
    > > Space after function name? You put in other places too, it's not
    > > consistent with the rest of the patch.
    >
    > Oops. I was also coding on a different project recently, with a
    > different style. I'll send a revised patch in a moment.

    Please change if()'s to use

    if (var == constant)
    instead of
    if (constant == var)

    also. (or whatever condition is being used) Thanks.


    > > > + if (pci_enable_device(pdev))
    > > > + printk (KERN_ERR "%s: device setup failed most egregiously\n",
    > > > + sym_name(np));
    > >
    > > Is the failure of pci_enable_device ignored on purpose?
    >
    > No. :-( Thanks for the catch. I think I got cross-eyed staring at the code.

    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-23 01:41    [W:0.020 / U:61.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site