lkml.org 
[lkml]   [2006]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

    Hi Linas,

    Linas Vepstas <linas@austin.ibm.com> ha scritto:
    > Index: linux-2.6.18-rc7-git1/drivers/scsi/sym53c8xx_2/sym_glue.c
    > ===================================================================
    > --- linux-2.6.18-rc7-git1.orig/drivers/scsi/sym53c8xx_2/sym_glue.c 2006-09-21 17:32:54.000000000 -0500
    > +++ linux-2.6.18-rc7-git1/drivers/scsi/sym53c8xx_2/sym_glue.c 2006-09-21 17:35:37.000000000 -0500
    > +/**
    > + * sym2_io_slot_reset() -- called when the pci bus has been reset.
    > + * @pdev: pointer to PCI device
    > + *
    > + * Restart the card from scratch.
    > + */
    > +static pci_ers_result_t sym2_io_slot_reset (struct pci_dev *pdev)
    > +{
    > + struct sym_hcb *np = pci_get_drvdata(pdev);
    > +
    > + printk (KERN_INFO "%s: recovering from a PCI slot reset\n",

    Space after function name? You put in other places too, it's not
    consistent with the rest of the patch.

    > + sym_name(np));
    > +
    > + if (pci_enable_device(pdev))
    > + printk (KERN_ERR "%s: device setup failed most egregiously\n",
    > + sym_name(np));

    Is the failure of pci_enable_device ignored on purpose?
    (plus extra space)

    > +
    > + pci_set_master(pdev);
    > + enable_irq (pdev->irq);

    Spurious space.

    > +
    > + /* Perform host reset only on one instance of the card */
    > + if (0 == PCI_FUNC (pdev->devfn)) {

    Ditto.

    > + if (sym_reset_scsi_bus(np, 0)) {
    > + printk(KERN_ERR "%s: Unable to reset scsi host controller\n",
    > + sym_name(np));
    > + return PCI_ERS_RESULT_DISCONNECT;
    > + }
    > + sym_start_up (np, 1);

    Ditto.

    > + }
    > +
    > + return PCI_ERS_RESULT_RECOVERED;
    > +}


    Luca
    --
    "L'abilita` politica e` l'abilita` di prevedere quello che
    accadra` domani, la prossima settimana, il prossimo mese e
    l'anno prossimo. E di essere cosi` abili, piu` tardi,
    da spiegare perche' non e` accaduto."
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-23 00:09    [W:0.024 / U:1.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site