[lkml]   [2006]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    On Tue, 19 Sep 2006 23:02:11 -0700 (PDT)
    Alex Dubov <> wrote:

    > Driver for TI Flash Media card reader. At present, only MMC/SD
    > cards are supported.

    Could I ask where the information which permitted this (nice-looking) driver to
    be written came from?


    There's some whitespace damage in there. Please search the diff for "^ "
    and fix it up.

    We indent the body of switch statements one tab stop less than this driver

    The driver has lots of really big inlined functions. It's best to uninline
    these. If the function has a single callsite, gcc will inline it anyway.
    If the function has multiple callsites (now, or in the future), inlining it
    is undesirable.

    The driver has a lot of things like

    static inline void* tifm_get_drvdata(struct tifm_dev *dev)

    whereas we prefer

    static inline void *tifm_get_drvdata(struct tifm_dev *dev)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-09-20 08:25    [W:0.022 / U:1.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site