lkml.org 
[lkml]   [2006]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    On Wed, Sep 20, 2006 at 09:28:05AM +0300, Pekka Enberg wrote:
    > On 9/20/06, Andrew Morton <akpm@osdl.org> wrote:
    > > Trivia:
    >
    > [snip]
    >
    > More trivia:
    >
    > - Unnecessary casts for void pointers
    > - Assignment in if statement expression

    also

    +#include <linux/config.h>
    +#include <linux/module.h>
    +#include <linux/kernel.h>

    Some unnecessary includes there. (config.h & kernel.h are auto-included)

    Dave
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-20 18:41    [W:0.022 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site