lkml.org 
[lkml]   [2006]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Date
From
SubjectRe: [PATCH] mpparse.c:231: warning: comparison is always false
On Fri, Sep 15, 2006 at 12:33:40PM -0700, Andrew Morton wrote:
> On Fri, 15 Sep 2006 11:23:49 -0400
> Dave Jones <davej@redhat.com> wrote:
>
> > On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote:
> >
> > > > > Thanks. Andi has already queued a similar patch.
> > > > >
> > > > > Andi, you might as well scoot that upstream, otherwise we'll get lots of
> > > > > emails about it.
> > > > ...
> > > > > > +#if 0xFF >= MAX_MP_BUSSES
> > > > > > if (m->mpc_busid >= MAX_MP_BUSSES) {
> > > > I don't know how Andi has fixed it,
> > > Same thing. (He has `#if MAX_MP_BUSSES < 256').
> >
> > How can this be the right the right thing to do ?
> > It should *never* be >=256. mach-summit/mach-generic need fixing
> > to be 255, not this ridiculous band-aid. Where did 260 come from anyway?
> >
>
> commit f0bacaf5cec4e677a00b5ab06d95664d03a30f7a
> Author: akpm <akpm>
> Date: Mon Apr 12 20:06:32 2004 +0000
>
> [PATCH] summmit: increase MAX_MP_BUSSES
>
> From: James Cleverdon <jamesclv@us.ibm.com>
>
> Bump up MAX_MP_BUSSES for summit/generic subarch to cope with big IBM x440
> systems.

The 260 is because ACPI can create larger busses and the summit
boxes only run with ACPI anyways.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-16 08:23    [W:0.283 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site