Messages in this thread | | | Date | Fri, 15 Sep 2006 11:08:19 +0200 | From | Jarek Poplawski <> | Subject | Re: [PATCH] mpparse.c:231: warning: comparison is always false |
| |
On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote: > On Fri, 15 Sep 2006 10:11:23 +0200 > Jarek Poplawski <jarkao2@o2.pl> wrote: > > As a matter of fact today I think my patch is wrong. ... > No, I think it's OK. Well, you had an off-by-one...
just like the source:
> +#if 0xFF >= MAX_MP_BUSSES > if (m->mpc_busid >= MAX_MP_BUSSES) {
... > > but after rethinking > > the question of Dave Jones I see it's fixing the result > > instead of the source of a problem (char or not char). > > The mpc_busid field is set to eight-bits by BIOS; there's nothing we can do > about that...
So IMHO maybe: if we can know this only by BIOS it should be eight-bits - if there is another way to get this: shouln't you add second constant? Now it's unlogical for me (and it induces this strange #ifs in the code instead of headers).
Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |