lkml.org 
[lkml]   [2006]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [01/12] driver core fixes: make_class_name() retval check
hoi :)

On Wed, Sep 13, 2006 at 06:38:34PM +0200, Cornelia Huck wrote:
> if (class_dev->dev) {
> class_name = make_class_name(class_dev->class->name,
> &class_dev->kobj);
> + if (IS_ERR(class_name)) {
> + error = PTR_ERR(class_name);
> + class_name = NULL;
> + goto out6;
> + }

perhaps it makes sense to return NULL in make_class_name on error,
to have consistent error return values?

--
Martin Waitz
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-09-14 14:05    [W:0.034 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site