Messages in this thread | | | Date | Thu, 14 Sep 2006 12:11:39 +0200 | From | Patrick McHardy <> | Subject | Re: [PATCH] EtherIP tunnel driver (RFC 3378) |
| |
Joerg Roedel wrote: > On Thu, Sep 14, 2006 at 11:21:22AM +1000, Philip Craig wrote: > >>Joerg Roedel wrote: >> >>>+ To configure tunnels an extra tool is required. You can download >>>+ it from http://zlug.fh-zwickau.de/~joro/projects/ under the >>>+ EtherIP section. If unsure, say N. >> >>To obtain a list of tunnels, this tool calls SIOCGETTUNNEL >>(SIOCDEVPRIVATE + 0) for every device in /proc/net/dev. I don't think >>this is safe, but I don't have a solution for you. > > > You are right. But this is the way the ipip driver does it. In the case > of ipip it is safe, because it is visible as a tunnel interface to > userspace. But my driver registers its devices as Ethernet (it has to, > otherwise the devices will not be usable in a bridge). There is no safe > way to distinguish between real Ethernet devices and devices registered > by my driver. I think about implementing an ioctl to fetch a list of > all EtherIP tunnel devices from the driver.
Just do what ipip and gre do, use a network device with a fixed name for the ioctl (you already have the ethip0 device for this purpose it appears).
>>Is there a reason why you have a separate tool rather than modifying >>iproute2? > > > I wrote an own tool for testing. At development I wanted to concentrate > on the driver and not how to modify iproute2. But when the driver > becomes stable and may be included I will add it to iproute2.
The iproute changes are only a few lines, just add the ethip0 device to the do_add, do_del, ... commands and set the protocol to IPPROTO_ETHERIP when an etherip tunnel is requested.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |