Messages in this thread | | | Date | Thu, 14 Sep 2006 02:35:42 -0400 | From | Dave Jones <> | Subject | Re: [PATCH] mpparse.c:231: warning: comparison is always false |
| |
On Thu, Sep 14, 2006 at 07:36:47AM +0200, Jarek Poplawski wrote: > On Wed, Sep 13, 2006 at 12:42:51PM -0400, Dave Jones wrote: > > On Wed, Sep 13, 2006 at 08:50:10AM +0200, Jarek Poplawski wrote: > ... > > > +#if 0xFF >= MAX_MP_BUSSES > > > if (m->mpc_busid >= MAX_MP_BUSSES) { > > > printk(KERN_WARNING "MP table busid value (%d) for bustype %s " > > > " is too large, max. supported is %d\n", > > > m->mpc_busid, str, MAX_MP_BUSSES - 1); > > > return; > > > } > > > +#endif > > > > mpc_busid is a uchar. I don't see how this can ever be > 0xff, yet > > mach-summit and mach-generic have MAX_MP_BUSSES set to 260. > > > > I don't see how this can possibly work. > > 0xFF >= 260 is false so the block is not compiled and > the warning is gone (+ several bytes of useless code).
Yes, I understand your patch. What I don't understand is why summit/generic have this set so high in the first place.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |