Messages in this thread | | | Date | Thu, 14 Sep 2006 11:24:35 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3] |
| |
Hi David,
On Wed, 13 Sep 2006 19:35:31 +0100 David Howells <dhowells@redhat.com> wrote: > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h > index a96b5d9..a7e374e 100644 > --- a/include/asm-generic/page.h > +++ b/include/asm-generic/page.h > @@ -6,20 +6,6 @@ #ifndef __ASSEMBLY__ > > #include <linux/compiler.h> > > -/* Pure 2^n version of get_order */ > -static __inline__ __attribute_const__ int get_order(unsigned long size) > -{ > - int order; > - > - size = (size - 1) >> (PAGE_SHIFT - 1); > - order = -1; > - do { > - size >>= 1; > - order++; > - } while (size); > - return order; > -} > - > #endif /* __ASSEMBLY__ */ > #endif /* __KERNEL__ */
After this patch, you don't need to include <linux/compiler.h> any more (and, in fact, the file ends up essentially empty). Is there a good reason to move this function out of asm-generic/page.h?
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |