lkml.org 
[lkml]   [2006]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 1/1] VFS: fixes a bug in sys_linkat()
Hardlink using sys_linkat() returns EXDEV when the source and the destination
point to the same filesystem, residing under different mounts.

An example scenario is:

mount /dev/sda /mnt
mount /dev/sdb /mnt1
mkdir /mnt1/src
mkdir /mnt/dest
mount --bind /mnt1/src /mnt/dest (note: at this point the filesystems
under /mnt1/src and /mnt/dest is same)
touch /mnt1/src/testfile
ln /mnt1/src/testfile /mnt/dest/sametestfile (note: this should succeed).

The ln command fails. It does not correctly recognize that both
the source and destination point to the same filesystem.

The following patch fixes the problem.
Thanks to Nishanth Aravamudan(nacc@us.ibm.com) for identifying the bug.

Signed by Ram Pai (linuxram@us.ibm.com)
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.17.10/fs/namei.c
===================================================================
--- linux-2.6.17.10.orig/fs/namei.c
+++ linux-2.6.17.10/fs/namei.c
@@ -2263,7 +2263,7 @@ asmlinkage long sys_linkat(int olddfd, c
if (error)
goto out;
error = -EXDEV;
- if (old_nd.mnt != nd.mnt)
+ if (old_nd.mnt->mnt_sb != nd.mnt->mnt_sb)
goto out_release;
new_dentry = lookup_create(&nd, 0);
error = PTR_ERR(new_dentry);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-09-13 03:01    [from the cache]
©2003-2011 Jasper Spaans