lkml.org 
[lkml]   [2006]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[-mm patch] arm build fail: vfpsingle.c
    On Tue, Sep 12, 2006 at 12:06:18AM -0700, Andrew Morton wrote:
    >
    > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/
    >
    Hi,

    It looks like Zach Brown's patch pr_debug-check-pr_debug-arguments
    worked as inteded. That is, it doesn't "allow completely incorrect code
    to build." :).

    The arm build fails with the following message:
    CC arch/arm/vfp/vfpsingle.o
    arch/arm/vfp/vfpsingle.c: In function `__vfp_single_normaliseround':
    arch/arm/vfp/vfpsingle.c:201: error: `func' undeclared (first use in
    this function)
    arch/arm/vfp/vfpsingle.c:201: error: (Each undeclared identifier is
    reported only once
    arch/arm/vfp/vfpsingle.c:201: error: for each function it appears in.)
    make[1]: *** [arch/arm/vfp/vfpsingle.o] Error 1
    make: *** [arch/arm/vfp] Error 2

    The following patch fixes the issue by using func only when DEBUG is
    defined.

    Regards,
    Frederik


    Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

    --- 2.6.18-rc6-mm2/arch/arm/vfp/vfpsingle.c~ 2006-09-12 19:57:50 +0000
    +++ 2.6.18-rc6-mm2/arch/arm/vfp/vfpsingle.c 2006-09-12 19:58:07 +0000
    @@ -198,8 +198,10 @@ u32 vfp_single_normaliseround(int sd, st
    vfp_single_dump("pack: final", vs);
    {
    s32 d = vfp_single_pack(vs);
    +#ifdef DEBUG
    pr_debug("VFP: %s: d(s%d)=%08x exceptions=%08x\n", func,
    sd, d, exceptions);
    +#endif
    vfp_put_float(d, sd);
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-09-12 20:09    [W:0.027 / U:1.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site