Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] quirks: Flag up and handle the AMD 8151 Errata #24 | Date | Tue, 12 Sep 2006 17:29:11 +0200 |
| |
On Tuesday 12 September 2006 19:13, Alan Cox wrote: > Ar Maw, 2006-09-12 am 17:10 +0200, ysgrifennodd Andi Kleen: > > On Tuesday 12 September 2006 18:29, Alan Cox wrote: > > > AMD states the following > > > > > > "Some PCI cards generate peer-to-peer posted-write traffic targetting > > > the AGP bridge (from the PCI bus, through the graphics tunnel to the > > > AGP bus). The combination of such cards and some AGP cards can generate > > > traffic patters that result in a system deadlock." > > > > Hmm, you add all that code just to trigger printks? Looks like overkill > > to me. > > Firstly it's important users get the correct messages about hardware > problems and don't just assume Linux sucks.
If the system really locks up afterwards they will likely never see it though?
I just don't think the printk will that useful and if it locks up people will blame Linux anyways even with printk.
> And "all that code" is a single quirk (which I think can be __init as > you can't get a hotplug bridge) and updated logic checks which my gcc > generates the same amount of code for as it did previously. > > All what code ?
Well it was a large change.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |