Messages in this thread | | | Subject | Re: [PATCH] Prevent legacy io access on pmac | From | Benjamin Herrenschmidt <> | Date | Tue, 12 Sep 2006 09:14:25 +1000 |
| |
On Mon, 2006-09-11 at 13:53 +0200, Olaf Hering wrote: > The ppc32 common config runs also on PReP/CHRP, which uses PC style IO > devices. The probing is bogus, it crashes or floods dmesg. > > ppc can boot one single binary on prep, chrp and pmac boards. > ppc64 can boot one single binary on pseries and G5 boards. > pmac has no legacy io, probing for PC style legacy hardware leads to a > hard crash: > > * add check for parport_pc, exit on pmac. > 32bit chrp has no ->check_legacy_ioport, the probe is always called. > 64bit chrp has check_legacy_ioport, check for a "parallel" node > > * add check for isapnp, only PReP boards may have real ISA slots. > 32bit PReP will have no ->check_legacy_ioport, the probe is always called. > > * update code in i8042_platform_init. Run ->check_legacy_ioport first, always > call request_region. No functional change. Remove whitespace before i8042_reset init. > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
Looks good to me.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |