lkml.org 
[lkml]   [2006]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vt: Rework the console spawning variables.
On 09/09, Eric W. Biederman wrote:
>
> This patch does several things.
> - The variables used are moved into a structure and declared in vt_kern.h
> - A spinlock is added so we don't have SMP races updating the values.
> - Instead of raw pid_t value a struct_pid is used to guard against
> pid wrap around issues, if the daemon to spawn a new console dies.

I am not arguing against this patch, but it's a pity we can't use 'struct pid'
lockless. What dou you think about this:

void delayed_free_pid(struct rcu_head *rhp)
{
struct pid *pid = container_of(rhp, struct pid, rcu);
kmem_cache_free(pid_cachep, pid);
}

void put_pid_rcu(struct pid *pid)
{
if (atomic_dec_and_test(&pid->count))
// this can happen only if delayed_put_pid()
// was already fired, we can re-use pid->rcu
call_rcu(&pid->rcu, delayed_free_pid);
}

Now,

update_pid()
{
// still needs some locking
put_pid_rcu(pid);
pid = get_pid(...);
}

use_pid()
{
rcu_read_lock();
do_something(pid);
rcu_read_unock();
}

Thoughts?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-10 16:33    [W:7.859 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site