lkml.org 
[lkml]   [2006]   [Sep]   [10]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC]: New termios take 2
FromDavid Woodhouse <>
DateSun, 10 Sep 2006 11:46:20 +0100
On Tue, 2006-09-05 at 17:14 +0100, Alan Cox wrote:
> +
> +#define TCGETS2                _IOR('T',0x2A, struct termios)
> +#define TCSETS2                _IOW('T',0x2B, struct termios)
> +#define TCSETSW2       _IOW('T',0x2C, struct termios)
> +#define TCSETSF2       _IOW('T',0x2D, struct termios)

So existing code compiled against this will be using the new 'struct
termios' but the old TCGETS. Should we rename the existing ioctl to 
TCGETS_OLD, and have TCGETS be the new one?

I suppose to a large extent it doesn't really matter as long as existing
C libraries happen to get it right -- and since the new structure only
has the new field added, the discrepancy shouldn't matter _too_ much.
But still...

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-10 12:49    [from the cache]
©2003-2008