Messages in this thread | | | Date | Sun, 10 Sep 2006 11:12:49 -0700 | From | Pete Zaitcev <> | Subject | Re: [PATCH] usb: Fixup usb so it uses struct pid |
| |
On Sat, 09 Sep 2006 22:42:10 -0600, ebiederm@xmission.com (Eric W. Biederman) wrote:
> The problem by remember a user space process by it's pid it is > possible that the process will exit, pid wrap around will occur and a > different process will appear in it's place.
... which is completely all right in this case. We used to have an implementation which tried to hold onto the task_struct and that sucked. It is only possible for the task to disappear without notifying devio under very special conditions only, which involve forking with parent exiting. In other words, even a buggy application won't trigger this without deliberately trying. And when it happens, uid checks make sure that other users are not affected.
> Holding a reference > to a struct pid avoid that problem, and paves the way > for implementing a pid namespace.
That may be useful.
The patch itself seems straightforward if we can trust your struct pid thingies. If OpenVZ people approve, I don't mind.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |