Messages in this thread | | | Subject | Re: [patch 3/9] Guest page hinting: volatile page cache. | From | Dave Hansen <> | Date | Fri, 01 Sep 2006 08:37:54 -0700 |
| |
On Fri, 2006-09-01 at 17:29 +0200, Martin Schwidefsky wrote: > On Fri, 2006-09-01 at 07:54 -0700, Dave Hansen wrote: > > Are all of the un/likely()s in here really needed? > > Well, no un/likely is really needed. But they do help the compiler to > generate better code. It IS unlikely that a page is discarded.
I know what they're _for_. ;)
I seem to recall people being poked in the past for sprinkling too many of these things around their code. I just wanted to make sure that there was some tangible reason for doing it, other than speculative performance optimization.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |