lkml.org 
[lkml]   [2006]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] not empty pages list after fuse_readpages
From
Date
On Thu, 2006-08-10 at 00:20 +0400, Alexander Zarochentsev wrote:
>
> }
> + if (0) {
> +clean_pages_up:
> + readpages_cleanup_helper(pages);
> + }
> return err;
> }

If the list is really empty during a normal exit, does it hurt to call
the helper? The whole goto inside of an if(0) statement looks a little
funky.

The following would be the same number of lines of code, and this is
used pretty commonly in the kernel:

return err;
clean_pages_up:
readpages_cleanup_helper(pages);
return err;

But, I really wonder what is wrong with this:

clean_pages_up:
readpages_cleanup_helper(pages);
return err;

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-09 23:05    [W:0.045 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site