Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/3] Kprobes: Define retval helper | Date | Wed, 09 Aug 2006 14:16:04 +0100 |
| |
Christoph Hellwig <hch@infradead.org> wrote:
> > > Good idea. You should add parentheses around regs, otherwise the C > > > preprocessor might bite users. Also the shouting name is quite ugly. > > > In fact it should probably go to asm/system.h or similar and not have > > > a kprobes name - it just extracts the return value from a struct pt_regs > > > after all. > > > > Done! How does this look? I added it to asm/ptrace.h so it lives along > > with the instruction_pointer() definition.
I presume we don't care about return values that span multiple registers - for instance if you return a 64-bit value on i386 it'll wind up in EDX:EAX.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |