Messages in this thread | | | Date | Tue, 8 Aug 2006 12:45:48 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload |
| |
Hi!
> This patch disables accelerometer power and stops its polling by the > embedded controller upon suspend and module unload. The power saving > is negligible, but it's the right thing to do. > > Signed-off-by: Shem Multinymous <multinymous@gmail.com>
Signed-off-by: Pavel Machek <pavel@suse.cz>
> +/* > + * hdaps_device_shutdown - power off the accelerometer. Can sleep. > + */ > +static void hdaps_device_shutdown(void) {
{ on newline?
> + if (hdaps_set_power(0)) > + printk(KERN_WARNING "hdaps: cannot power off\n"); > + if (hdaps_set_ec_config(0, 1)) > + printk(KERN_WARNING "hdaps: cannot stop EC sampling\n"); > +}
Maybe propagate error value?
> +static int hdaps_suspend(struct platform_device *dev, pm_message_t state) > +{ > + hdaps_device_shutdown(); > + return 0; > +} > +
-- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |