lkml.org 
[lkml]   [2006]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
    On Mon, Aug 07, 2006 at 08:20:47PM +0200, Björn Steinbrink wrote:
    > On 2006.08.07 19:30:55 +0300, Shem Multinymous wrote:
    > > Hi Pavel,
    > >
    > > On 8/7/06, Pavel Machek <pavel@suse.cz> wrote:
    > > >> + int total, ret;
    > > >> + for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {
    > > >
    > > >Could we go from 0 to timeout, not the other way around?
    > >
    > > Sure.
    > > (That's actually vanilla hdapsd code, moved around...)
    >
    > Maybe you could convert that to sth. like this along the way?
    >
    > int ret;
    > unsigned long timeout = jiffies + msec_to_jiffies(READ_TIMEOUT_MSECS);
    > for (;;) {
    > ret = thinkpad_ec_lock();
    > if (ret)
    > return ret;

    Just in case someone was going to cut and paste, this will return with
    the ec_lock taken.

    Cheers,
    Muli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-08 14:25    [W:0.023 / U:31.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site