Messages in this thread | | | Date | Mon, 7 Aug 2006 20:08:04 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH 0/9] Replace some ARCH_HAS_XYZZY |
| |
On Tue, 8 Aug 2006 04:05:11 +0200 Andi Kleen wrote:
> On Monday 07 August 2006 23:13, Randy.Dunlap wrote: > > On Mon, 3 Jul 2006 10:13:12 -0700 (PDT) Linus Torvalds wrote: > > > > [snip] > > > > > The whole "ARCH_HAS_XYZZY" is nothing but crap. It's totally unreadable, > > ... > > > WE SHOULD GET RID OF ARCH_HAS_XYZZY. It's a disease. > > > > Using Kconfig symbols for some of them seems more appropriate to me, > > IMHO that's no better. > > Instead one should add dummy inlines/macros or asm-generic dummy inlines/macros > to all the architectures.
They are config characteristics (in many cases). Hiding them in header files with dummy inlines or with ARCH_HAS_XYZZY is still hiding them IMO, although the inlines are better than the ARCH_HAS_XYZZY method. I prefer to see them in the config space since I think that's where they belong.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |