Messages in this thread | | | Date | Tue, 8 Aug 2006 01:26:25 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes |
| |
On Mon 2006-08-07 19:30:55, Shem Multinymous wrote: > Hi Pavel, > > On 8/7/06, Pavel Machek <pavel@suse.cz> wrote: > >> + int total, ret; > >> + for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) { > > > >Could we go from 0 to timeout, not the other way around? > > Sure. > (That's actually vanilla hdapsd code, moved around...)
Thanks for cleaning it up :-).
> >This actually changes userland interface... but that is probably okay. > > Those two sysfs attributes were bogus. If anything used them (which I > very much doubt), it's a good thing we broke it.
Okay, just make sure you note this in the changelog. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |