Messages in this thread |  | | | Date | Tue, 8 Aug 2006 01:24:15 +0200 | | From | Pavel Machek <> | | Subject | Re: [PATCH 03/12] hdaps: Unify and cache hdaps readouts |
| |
Hi!
> >> + /* Parse position data: */ > >> + pos_x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS1) * (hdaps_invert?-1:1); > >> + pos_y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS1) * (hdaps_invert?-1:1); > >> + > >> + /* Parse so-called "variance" data: */ > >> + var_x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS2) * (hdaps_invert?-1:1); > >> + var_y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS2) * (hdaps_invert?-1:1); > > > >Perhaps hdaps_invert should already have 1/-1 values. > > It's also used as a module parameter, which is 0/1 in mainline. I > don't think this is worth extra code.
Okay, so what about ..
#define CONVERT(x) *(s16*)(data.val+x) * (hdaps_invert?-1:1);
...or better inline function?
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |