lkml.org 
[lkml]   [2006]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access
    On Tue, Aug 08, 2006 at 01:15:57AM +0200, Pavel Machek wrote:
    > Hi!
    >
    > > Thanks for the sign-offs!
    >
    > No problem.
    >
    > > >> +module_param_named(debug, tp_debug, int, 0600);
    > > >> +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
    > > >> +
    > > >> +/* A few macros for printk()ing: */
    > > >> +#define DPRINTK(fmt, args...) \
    > > >> + do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
    > > >
    > > >Is not there generic function doing this?
    > >
    > > None that I found. Many drivers do it this way.
    >
    > linux/kernel.h : pr_debug() looks similar.

    Use dev_dbg() and friends please instead of rolling your own.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-08 01:27    [W:0.021 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site