Messages in this thread | | | Date | Mon, 7 Aug 2006 16:07:02 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH -mm] [2/2] Add the Elevator I/O scheduler |
| |
On Thu, 3 Aug 2006, Daniel Phillips wrote:
> Dave Jones wrote: > > > +/**************** > > > + * > > > + * Advantages of the Textbook Elevator Algorithms > > > + * by Hans Reiser > > > + * > > > + * In people elevators, they ensure that the elevator never changes > > > + * direction before it reaches the last floor in a given direction to which > > > + * there is a request to go to it. A difference with people elevators is > > > + * that disk drives have a preferred direction due to disk spin direction > > > + * being fixed, and large seeks are relatively cheap, and so we (and every > > > + * textbook) have a one way elevator in which we go back to the beginning > > > > blah blah blah.. > > > > This huge writeup would probably belong more in Documentation/ > > Hi Dave, > > Surely you did not mean to characterize his documentation as blather?
No he's just pointing out that it goes on and on and on...
> It seems > to be of very good quality, we need to encourage that level of diligence. As > far as moving it to Documentation goes, my immediate reaction is I sure do like > it when the coder cares enough about my understanding of what he's doing to > put such effort into trying to make sure I understand what he's doing and why > he's doing it. Having it right in the code removes a level of indirection when > reading that might make the difference between me reading and not reading the > documentation, which in turn might make the difference between understanding and > not understanding the code. Agreed it's a bit much at least all in one piece. > > Maybe precis the in-line documenation and move the greater literary effort to > Documentation, with the requisite "see Documentation/" line? >
Yes a "see Documentation/" line would be much more appropriate.
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |