lkml.org 
[lkml]   [2006]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
On 8/7/06, Pavel Machek <pavel@suse.cz> wrote:
> > + /* Parse position data: */
> > + pos_x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS1) * (hdaps_invert?-1:1);
> > + pos_y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS1) * (hdaps_invert?-1:1);
> > +
> > + /* Parse so-called "variance" data: */
> > + var_x = *(s16*)(data.val+EC_ACCEL_IDX_XPOS2) * (hdaps_invert?-1:1);
> > + var_y = *(s16*)(data.val+EC_ACCEL_IDX_YPOS2) * (hdaps_invert?-1:1);
>
> Perhaps hdaps_invert should already have 1/-1 values.

It's also used as a module parameter, which is 0/1 in mainline. I
don't think this is worth extra code.


> > {
> > - int ret = thinkpad_ec_lock();
> > + int ret;
> > + ret = thinkpad_ec_lock();
>
> I actually liked the previous version more, and this change does not
> really belong here.

(That's a diff artifact, it's a totally different function...)
Changed to the version you like.

Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-07 18:17    [W:0.076 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site