Messages in this thread | | | Date | Sat, 5 Aug 2006 11:37:04 +0000 | From | Pavel Machek <> | Subject | Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h |
| |
Hi!
> > We have BUG_ON() right for this, don't we? > > Well yes, but there are over a thousand BUG->BUG_ON conversion > possibilities in the tree. If people start sending them three-at-a-time > we'll all go mad. > > So. If we're going to do this, bigger patches, please.
If we are going that way... I guess we should specify if BUG_ON() has to evaluate its arguments even if it is compiled out...
Or probably better pecify that BUG_ON() must not have side effects?
Pavel -- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |