Messages in this thread | | | Date | Sun, 6 Aug 2006 22:05:09 +0100 | From | Russell King <> | Subject | Re: [PATCH] [MMC] Fix base address configuration in wbsd |
| |
On Sun, Aug 06, 2006 at 10:57:35PM +0200, Pierre Ossman wrote: > Russell King wrote: > > On Sun, Aug 06, 2006 at 10:22:23PM +0200, Pierre Ossman wrote: > >> There were some confusion about base I/O variables in the wbsd driver. > >> Seems like things have been working on shear luck so far. The global 'io' > >> variable (used when manually configuring the resources) was used instead of > >> the local 'base' variable. > > > > Applied, thanks. > > > > Shouldn't "base" be something other than "int" (eg, unsigned long) ? > > unsigned short would probably be the right<tm> thing as the resource is > 16 bits. I haven't seen it as big enough issue to warrant a patch.
Is that a safe assumption to make? Is this only ever going to appear/be used on x86?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |