Messages in this thread | | | Date | Fri, 04 Aug 2006 18:17:13 +0300 | From | Mika Penttilä <> | Subject | Re: [Lhms-devel] [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEM in srat.c |
| |
Keith Mannthey wrote: > From: Keith Mannthey <kmannth@us.ibm.com> > > Enable x86_64 srat.c to share code between both reserve and sparsemem based add memory > paths. Both paths need the hot-add area node locality infomration (nodes_add). This > code refactors the code path to allow this. > > Signed-off-by: Keith Mannthey<kmannth@us.ibm.com> > Ok nice, but.... hotadd_enough_memory() is broken, it does weird things with nd->start and nd->end which haven't been assigned even values yet. Also, mysterious business with find_e820_area and last_area_end...These areas are not in e820...
And why the reserve_bootmem_node()? Areas not RAM (per e820) are reserved anyways.
--Mika
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |