[lkml]   [2006]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 19/19] BLOCK: Make it possible to disable the block layer [try #6]

    I think I'll just slam all this in at the first opportunity. Stuff will
    break, but it will be easy to fix.

    If you try to upissue this patchset I shall be seeking an IP-routable hand

    On Tue, 29 Aug 2006 19:06:34 +0100
    David Howells <> wrote:

    > +static inline long blk_congestion_wait(int rw, long timeout)
    > +{
    > + return timeout;
    > +}

    This function is misnamed and is implemented in the wrong place. It's not
    really a block thing at all. If/when/soon NFS starts to implement it and
    call it, things will need to be renamed and reshuffled.

    Simply stubbing it out like this will cause general mayhem and CPU meltdown
    all over the writeback and page-reclaim code.

    So... for now, I'll replace it with a simple io_schedule_timeout(timeout),
    which is equivalent to what we do now for network filesystems.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-08-30 21:47    [W:0.039 / U:127.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site