lkml.org 
[lkml]   [2006]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping)
    Andi Kleen wrote:
    > On Wednesday 30 August 2006 20:59, H. Peter Anvin wrote:
    >> Alon Bar-Lev wrote:
    >>> This is not entirely true...
    >>> All architectures sets saved_command_line variable...
    >>> So I can add __init to the saved_command_line and
    >>> copy its contents into kmalloced persistence_command_line at
    >>> main.c.
    >>>
    >> My opinion is that you should change saved_command_line (which already
    >> implies a copy) to be the kmalloc'd version and call the fixed-sized
    >> buffer something else.
    >
    > It might be safer to rename everything. Then all users could be caught
    > and audited. This would ensure saved_command_line is not accessed
    > before the kmalloc'ed copy exists.
    >
    > Disadvantage: more architectures to change.
    >

    That would definitely be the safest option, and probably is the way to go.

    -hpa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-30 21:11    [W:0.024 / U:89.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site