lkml.org 
[lkml]   [2006]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [S390] cio: kernel stack overflow.
    Date
    Have you checked that in all cases all fields of the struct have
    been overwritten? For instance, look at this:

    Martin Schwidefsky wrote:
    >- chp->dev = (struct device) {
    >- .parent = &css[0]->device,
    >- .release = chp_release,
    >- };
    >+ chp->dev.parent = &css[0]->device;
    >+ chp->dev.release = chp_release;

    Doesn't this leave chp->dev.bus still holding whatever old value it
    had laying around before? Unless I'm missing something, it looks to
    me like this diff causes a change in the semantics of the code.

    Perhaps it would be better to memset() the entire struct (chp->dev, in
    this case) to zero, before assigning to individual fields, so there is
    no possibility of old remnant data still being left laying around?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-30 19:11    [W:0.021 / U:119.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site