Messages in this thread | | | Date | Thu, 3 Aug 2006 10:23:52 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code |
| |
On Thu, Aug 03, 2006 at 08:25:19AM +0200, Rolf Eike Beer wrote:
> > ./arch/x86_64/kernel/pci-swiotlb.c:6:#include <asm/dma-mapping.h> > > ./drivers/net/fec_8xx/fec_main.c:40:#include <asm/dma-mapping.h> > > ./drivers/net/fs_enet/fs_enet.h:11:#include <asm/dma-mapping.h> > > ./include/asm-x86_64/swiotlb.h:5:#include <asm/dma-mapping.h> > > I suspect it to be a bug anyway that every of this files ever included > asm/dma-mapping.h.
Agreed wrt the fs_enet and fec_8xx; the swiotlb stuff I dimly recall I had a reason for. I'll take a look in bit to verify akpm's fix works.
> > ./include/linux/dma-mapping.h:27:#include <asm/dma-mapping.h> > > This is perfectly valid, isn't it :)
:-)
Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |