[lkml]   [2006]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] eicon: fix define conflict with ptrace
    On Thu, Aug 03, 2006 at 10:09:59PM +0100, Alan Cox wrote:
    > Ar Gwe, 2006-08-04 am 00:34 +0400, ysgrifennodd Alexey Dobriyan:
    > > * MODE_MASK is unused in eicon driver.
    > > * Conflicts with a ptrace stuff on arm.
    > >
    > > drivers/isdn/hardware/eicon/divasync.h:259:1: warning: "MODE_MASK" redefined
    > > include2/asm/ptrace.h:48:1: warning: this is the location of the previous definition

    > NAK. You need to fix all the code expecting to use the MODE_MASK with a
    > value of 0x00000080

    OK, I understood. However, judging by tiny amount of indentation¹ this
    define should be used when messing with "Flag" field

    unsigned long Flag; /* |31-Type-16|15-Mask-0| */

    of struct (typedef, actually) called "isdnProps". Other defines nearby
    are unused also. More, "isdnProps" which is typedef holding this field in
    turn, is also unused.

    ¹ Even less than GNU.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-08-03 23:19    [W:0.020 / U:13.488 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site